Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize injection on Iframes #1199

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Optimize injection on Iframes #1199

merged 4 commits into from
Nov 14, 2019

Conversation

brunobar79
Copy link
Contributor

FWD only the requests that don't belong to the main frame.

@ibrahimtaveras00 ibrahimtaveras00 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 14, 2019
ibrahimtaveras00
ibrahimtaveras00 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@brunobar79 brunobar79 merged commit 666e4eb into develop Nov 14, 2019
@brunobar79 brunobar79 deleted the ck-issue branch November 14, 2019 05:02
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Optimize injection on Iframes (#1199)
1a47c41 
* check main frame, then try iframes

* fix ios device names

* fix

* remove console logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobar79 @ibrahimtaveras00